From 9cbbcb96b3c3f1a95d60a870da4e835a111b5abd Mon Sep 17 00:00:00 2001
From: Fabian <43351274+0xk1f0@users.noreply.github.com>
Date: Sat, 17 Feb 2024 16:30:11 +0100
Subject: [PATCH] Potential fix for `for`-loop memory leak (#1010)

* fix for-loop memory leak

* remove additional unsafe call
---
 crates/eww/src/widgets/build_widget.rs | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/crates/eww/src/widgets/build_widget.rs b/crates/eww/src/widgets/build_widget.rs
index 52855d0..2ba7c26 100644
--- a/crates/eww/src/widgets/build_widget.rs
+++ b/crates/eww/src/widgets/build_widget.rs
@@ -246,7 +246,7 @@ fn build_loop_special_widget(
                         .collect_vec();
                     let mut created_children = created_children.borrow_mut();
                     for old_child in created_children.drain(..) {
-                        unsafe { old_child.destroy() };
+                        gtk_container.remove(&old_child);
                     }
                     let mut created_child_scopes = created_child_scopes.borrow_mut();
                     for child_scope in created_child_scopes.drain(..) {
@@ -313,11 +313,7 @@ fn build_children_special_widget(
                             nth_child_widget_use.clone(),
                             None,
                         )?;
-                        for old_child in child_container.children() {
-                            unsafe {
-                                old_child.destroy();
-                            }
-                        }
+                        child_container.children().iter().for_each(|f| child_container.remove(f));
                         child_container.set_child(Some(&new_child_widget));
                         new_child_widget.show();
                         Ok(())