Add album list context menu

- Fix stale selected value when selecting single row with right click
This commit is contained in:
jeffvli 2022-12-28 19:19:51 -08:00
parent 9836d548a6
commit 131e3b3c65
3 changed files with 92 additions and 44 deletions

View file

@ -30,6 +30,7 @@ import {
import type { AgGridReact as AgGridReactType } from '@ag-grid-community/react/lib/agGridReact'; import type { AgGridReact as AgGridReactType } from '@ag-grid-community/react/lib/agGridReact';
import { import {
BodyScrollEvent, BodyScrollEvent,
CellContextMenuEvent,
ColDef, ColDef,
GridReadyEvent, GridReadyEvent,
IDatasource, IDatasource,
@ -37,6 +38,8 @@ import {
} from '@ag-grid-community/core'; } from '@ag-grid-community/core';
import { AnimatePresence } from 'framer-motion'; import { AnimatePresence } from 'framer-motion';
import debounce from 'lodash/debounce'; import debounce from 'lodash/debounce';
import { openContextMenu } from '/@/renderer/features/context-menu';
import { ALBUM_CONTEXT_MENU_ITEMS } from '/@/renderer/features/context-menu/context-menu-items';
interface AlbumListContentProps { interface AlbumListContentProps {
gridRef: MutableRefObject<VirtualInfiniteGridRef | null>; gridRef: MutableRefObject<VirtualInfiniteGridRef | null>;
@ -268,6 +271,29 @@ export const AlbumListContent = ({ gridRef, tableRef }: AlbumListContentProps) =
return rows; return rows;
}, [page.filter.sortBy]); }, [page.filter.sortBy]);
const handleContextMenu = (e: CellContextMenuEvent) => {
if (!e.event) return;
const clickEvent = e.event as MouseEvent;
clickEvent.preventDefault();
let selectedRows = e.api.getSelectedRows();
const selectedIds = selectedRows.map((row) => row.id);
if (!selectedIds.includes(e.data.id)) {
e.api.deselectAll();
e.node.setSelected(true);
selectedRows = [e.data];
}
openContextMenu({
data: selectedRows,
menuItems: ALBUM_CONTEXT_MENU_ITEMS,
type: LibraryItem.ALBUM,
xPos: clickEvent.clientX,
yPos: clickEvent.clientY,
});
};
return ( return (
<> <>
<VirtualGridAutoSizerContainer> <VirtualGridAutoSizerContainer>
@ -327,7 +353,7 @@ export const AlbumListContent = ({ gridRef, tableRef }: AlbumListContentProps) =
rowModelType="infinite" rowModelType="infinite"
rowSelection="multiple" rowSelection="multiple"
onBodyScrollEnd={handleTableScroll} onBodyScrollEnd={handleTableScroll}
onCellContextMenu={(e) => console.log('context', e)} onCellContextMenu={handleContextMenu}
onColumnMoved={handleTableColumnChange} onColumnMoved={handleTableColumnChange}
onColumnResized={debouncedTableColumnChange} onColumnResized={debouncedTableColumnChange}
onGridReady={onTableReady} onGridReady={onTableReady}

View file

@ -1,6 +1,6 @@
import { Stack } from '@mantine/core'; import { Stack } from '@mantine/core';
import { useClickOutside, useResizeObserver, useSetState, useViewportSize } from '@mantine/hooks'; import { useClickOutside, useResizeObserver, useSetState, useViewportSize } from '@mantine/hooks';
import { createContext, useMemo, useState } from 'react'; import { createContext, useState } from 'react';
import { ContextMenu, ContextMenuButton } from '/@/renderer/components'; import { ContextMenu, ContextMenuButton } from '/@/renderer/components';
import { import {
OpenContextMenuProps, OpenContextMenuProps,
@ -48,7 +48,8 @@ export const ContextMenuProvider = ({ children }: ContextMenuProviderProps) => {
const handlePlayQueueAdd = useHandlePlayQueueAdd(); const handlePlayQueueAdd = useHandlePlayQueueAdd();
const openContextMenu = (args: OpenContextMenuProps) => { const openContextMenu = (args: OpenContextMenuProps) => {
const { xPos, yPos, menuItems, data } = args; console.log('args.data', args.data);
const { xPos, yPos, menuItems, data, type } = args;
const shouldReverseY = yPos + menuRect.height > viewport.height; const shouldReverseY = yPos + menuRect.height > viewport.height;
const shouldReverseX = xPos + menuRect.width > viewport.width; const shouldReverseX = xPos + menuRect.width > viewport.width;
@ -56,7 +57,7 @@ export const ContextMenuProvider = ({ children }: ContextMenuProviderProps) => {
const calculatedXPos = shouldReverseX ? xPos - menuRect.width : xPos; const calculatedXPos = shouldReverseX ? xPos - menuRect.width : xPos;
const calculatedYPos = shouldReverseY ? yPos - menuRect.height : yPos; const calculatedYPos = shouldReverseY ? yPos - menuRect.height : yPos;
setCtx({ data, menuItems, xPos: calculatedXPos, yPos: calculatedYPos }); setCtx({ data, menuItems, type, xPos: calculatedXPos, yPos: calculatedYPos });
setOpened(true); setOpened(true);
}; };
@ -69,36 +70,57 @@ export const ContextMenuProvider = ({ children }: ContextMenuProviderProps) => {
openContextMenu, openContextMenu,
}); });
const contextMenuItems = useMemo(() => { const handlePlay = (play: Play) => {
return { console.log('ctx', ctx);
switch (ctx.type) {
case LibraryItem.ALBUM:
handlePlayQueueAdd({
byItemType: { id: ctx.data.map((item) => item.id), type: ctx.type },
play,
});
break;
case LibraryItem.ARTIST:
handlePlayQueueAdd({
byItemType: { id: ctx.data.map((item) => item.id), type: ctx.type },
play,
});
break;
case LibraryItem.ALBUM_ARTIST:
handlePlayQueueAdd({
byItemType: { id: ctx.data.map((item) => item.id), type: ctx.type },
play,
});
break;
case LibraryItem.SONG:
handlePlayQueueAdd({ byData: ctx.data, play });
break;
case LibraryItem.PLAYLIST:
handlePlayQueueAdd({
byItemType: { id: ctx.data.map((item) => item.id), type: ctx.type },
play,
});
break;
}
};
const contextMenuItems = {
addToFavorites: { id: 'addToFavorites', label: 'Add to favorites', onClick: () => {} }, addToFavorites: { id: 'addToFavorites', label: 'Add to favorites', onClick: () => {} },
addToPlaylist: { id: 'addToPlaylist', label: 'Add to playlist', onClick: () => {} }, addToPlaylist: { id: 'addToPlaylist', label: 'Add to playlist', onClick: () => {} },
play: { play: {
id: 'play', id: 'play',
label: 'Play', label: 'Play',
onClick: () => { onClick: () => handlePlay(Play.NOW),
if (ctx.type === LibraryItem.SONG) {
handlePlayQueueAdd({ byData: ctx.data, play: Play.NOW });
}
},
}, },
playLast: { playLast: {
id: 'playLast', id: 'playLast',
label: 'Play Last', label: 'Play Last',
onClick: () => { onClick: () => handlePlay(Play.LAST),
if (ctx.type === LibraryItem.SONG) {
handlePlayQueueAdd({ byData: ctx.data, play: Play.LAST });
}
},
}, },
playNext: { playNext: {
id: 'playNext', id: 'playNext',
label: 'Play Next', label: 'Play Next',
onClick: () => { onClick: () => handlePlay(Play.NEXT),
if (ctx.type === LibraryItem.SONG) {
handlePlayQueueAdd({ byData: ctx.data, play: Play.NEXT });
}
},
}, },
removeFromFavorites: { removeFromFavorites: {
id: 'removeFromFavorites', id: 'removeFromFavorites',
@ -107,7 +129,6 @@ export const ContextMenuProvider = ({ children }: ContextMenuProviderProps) => {
}, },
setRating: { id: 'setRating', label: 'Set rating', onClick: () => {} }, setRating: { id: 'setRating', label: 'Set rating', onClick: () => {} },
}; };
}, [ctx.data, ctx.type, handlePlayQueueAdd]);
return ( return (
<ContextMenuContext.Provider <ContextMenuContext.Provider

View file

@ -160,12 +160,13 @@ export const SongListContent = ({ tableRef }: SongListContentProps) => {
const clickEvent = e.event as MouseEvent; const clickEvent = e.event as MouseEvent;
clickEvent.preventDefault(); clickEvent.preventDefault();
const selectedRows = e.api.getSelectedRows(); let selectedRows = e.api.getSelectedRows();
const selectedUniqueIds = selectedRows.map((row) => row.uniqueId); const selectedUniqueIds = selectedRows.map((row) => row.uniqueId);
if (!selectedUniqueIds.includes(e.data.uniqueId)) { if (!selectedUniqueIds.includes(e.data.uniqueId)) {
e.api.deselectAll(); e.api.deselectAll();
e.node.setSelected(true); e.node.setSelected(true);
selectedRows = [e.data];
} }
openContextMenu({ openContextMenu({