From 84837a6887526385b703be2acc8b30022dbbe3d4 Mon Sep 17 00:00:00 2001 From: jeffvli Date: Sun, 3 Mar 2024 22:16:25 -0800 Subject: [PATCH] Prevent version check from running on every query in Navidrome --- src/renderer/hooks/use-server-version.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/renderer/hooks/use-server-version.ts b/src/renderer/hooks/use-server-version.ts index 5565457e..96245e76 100644 --- a/src/renderer/hooks/use-server-version.ts +++ b/src/renderer/hooks/use-server-version.ts @@ -23,14 +23,18 @@ export const useServerVersion = () => { }); useEffect(() => { - if (server && server.id === serverInfo.data?.id) { - const { version, features } = serverInfo.data; - if (version !== server.version || !isEqual(features, server.features)) { + if (!server?.id) { + return; + } + + if (server?.id === serverInfo.data?.id) { + const { version, features } = serverInfo.data || {}; + if (version !== server?.version || !isEqual(features, server?.features)) { updateServer(server.id, { features, version, }); } } - }, [server, serverInfo.data, updateServer]); + }, [serverInfo?.data, server?.features, server?.id, server?.version, updateServer]); };