From 8ec4551b46ff532d3790f23faa63f7ee472ffa33 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Wed, 13 Nov 2024 17:54:54 -0800
Subject: [PATCH] Encode credential for subsonic stream/coverart (#841)

---
 src/renderer/api/subsonic/subsonic-normalize.ts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/renderer/api/subsonic/subsonic-normalize.ts b/src/renderer/api/subsonic/subsonic-normalize.ts
index 43a4aad4..3465fec9 100644
--- a/src/renderer/api/subsonic/subsonic-normalize.ts
+++ b/src/renderer/api/subsonic/subsonic-normalize.ts
@@ -24,14 +24,15 @@ const getCoverArtUrl = (args: {
         return null;
     }
 
-    return (
+    const url =
         `${args.baseUrl}/rest/getCoverArt.view` +
         `?id=${args.coverArtId}` +
-        `&${args.credential}` +
+        `&${encodeURIComponent(args.credential || '')}` +
         '&v=1.13.0' +
         '&c=feishin' +
-        `&size=${size}`
-    );
+        `&size=${size}`;
+
+    return url;
 };
 
 const normalizeSong = (
@@ -48,7 +49,7 @@ const normalizeSong = (
             size: size || 300,
         }) || null;
 
-    const streamUrl = `${server?.url}/rest/stream.view?id=${item.id}&v=1.13.0&c=feishin_${deviceId}&${server?.credential}`;
+    const streamUrl = `${server?.url}/rest/stream.view?id=${item.id}&v=1.13.0&c=feishin_${deviceId}&${encodeURIComponent(server?.credential || '')}`;
 
     return {
         album: item.album || '',