From b87d7778dfdcab19a8ecf3b4a68c395e2f309979 Mon Sep 17 00:00:00 2001 From: jeffvli Date: Tue, 3 Jan 2023 01:49:01 -0800 Subject: [PATCH] Remove image placeholders (performance issues?) --- src/renderer/api/jellyfin.api.ts | 14 +++----------- src/renderer/api/navidrome.api.ts | 14 ++------------ 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/src/renderer/api/jellyfin.api.ts b/src/renderer/api/jellyfin.api.ts index c907849b..3d4abf98 100644 --- a/src/renderer/api/jellyfin.api.ts +++ b/src/renderer/api/jellyfin.api.ts @@ -620,7 +620,7 @@ const normalizeSong = ( duration: item.RunTimeTicks / 10000000, genres: item.GenreItems.map((entry: any) => ({ id: entry.Id, name: entry.Name })), id: item.Id, - imagePlaceholderUrl: getSongCoverArtUrl({ baseUrl: server.url, item, size: 1 }), + imagePlaceholderUrl: null, imageUrl: getSongCoverArtUrl({ baseUrl: server.url, item, size: imageSize || 300 }), isFavorite: (item.UserData && item.UserData.IsFavorite) || false, lastPlayedAt: null, @@ -661,11 +661,7 @@ const normalizeAlbum = (item: JFAlbum, server: ServerListItem, imageSize?: numbe duration: item.RunTimeTicks / 10000000, genres: item.GenreItems?.map((entry) => ({ id: entry.Id, name: entry.Name })), id: item.Id, - imagePlaceholderUrl: getAlbumCoverArtUrl({ - baseUrl: server.url, - item, - size: 1, - }), + imagePlaceholderUrl: null, imageUrl: getAlbumCoverArtUrl({ baseUrl: server.url, item, @@ -725,11 +721,7 @@ const normalizePlaylist = ( size: imageSize || 300, }); - const imagePlaceholderUrl = getPlaylistCoverArtUrl({ - baseUrl: server.url, - item, - size: 1, - }); + const imagePlaceholderUrl = null; return { description: item.Overview || null, diff --git a/src/renderer/api/navidrome.api.ts b/src/renderer/api/navidrome.api.ts index d9d7e280..67778a25 100644 --- a/src/renderer/api/navidrome.api.ts +++ b/src/renderer/api/navidrome.api.ts @@ -517,12 +517,7 @@ const normalizeAlbum = (item: NDAlbum, server: ServerListItem, imageSize?: numbe size: imageSize || 300, }); - const imagePlaceholderUrl = getCoverArtUrl({ - baseUrl: server.url, - coverArtId: item.coverArtId || item.id, - credential: server.credential, - size: 1, - }); + const imagePlaceholderUrl = null; const imageBackdropUrl = imageUrl?.replace(/size=\d+/, 'size=1000') || null; @@ -583,12 +578,7 @@ const normalizePlaylist = ( size: imageSize || 300, }); - const imagePlaceholderUrl = getCoverArtUrl({ - baseUrl: server.url, - coverArtId: item.id, - credential: server.credential, - size: 1, - }); + const imagePlaceholderUrl = null; return { description: item.comment,