From e45252d16cd3da2904b09234b0fa73b13c2b5d6a Mon Sep 17 00:00:00 2001 From: jeffvli Date: Wed, 17 May 2023 17:25:20 -0700 Subject: [PATCH] Fix mpv sample rate setting - Fix default input value - Disable property on 0 value --- .../settings/components/playback/mpv-settings.tsx | 12 +++++++----- src/renderer/store/settings.store.ts | 6 +++--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/renderer/features/settings/components/playback/mpv-settings.tsx b/src/renderer/features/settings/components/playback/mpv-settings.tsx index 2afb7347..4d8b1c6c 100644 --- a/src/renderer/features/settings/components/playback/mpv-settings.tsx +++ b/src/renderer/features/settings/components/playback/mpv-settings.tsx @@ -43,7 +43,7 @@ export const getMpvSetting = ( export const getMpvProperties = (settings: SettingsState['playback']['mpvProperties']) => { const properties: Record = { 'audio-exclusive': settings.audioExclusiveMode || 'no', - 'audio-samplerate': settings.audioSampleRateHz, + 'audio-samplerate': settings.audioSampleRateHz === 0 ? undefined : settings.audioSampleRateHz, 'gapless-audio': settings.gaplessAudio || 'weak', replaygain: settings.replayGainMode || 'no', 'replaygain-clip': settings.replayGainClip || 'no', @@ -182,17 +182,19 @@ export const MpvSettings = () => { { control: ( handleSetMpvProperty('audioSampleRateHz', e.currentTarget.value)} + onBlur={(e) => { + const value = Number(e.currentTarget.value); + handleSetMpvProperty('audioSampleRateHz', value > 0 ? value : undefined); + }} /> ), description: - 'Select the output sample rate to be used (of course sound cards have limits on this). If the sample frequency selected is different from that of the current media', + 'Select the output sample rate to be used if the sample frequency selected is different from that of the current media', isHidden: settings.type !== PlaybackType.LOCAL, title: 'Sample rate', }, - { control: (