From 597128717475ea6bde47ced438485a36b0c887be Mon Sep 17 00:00:00 2001 From: Martin Rotter Date: Thu, 5 Aug 2021 08:57:29 +0200 Subject: [PATCH] fix unreachable code --- resources/desktop/com.github.rssguard.appdata.xml | 2 +- src/librssguard/services/greader/greaderserviceroot.cpp | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/resources/desktop/com.github.rssguard.appdata.xml b/resources/desktop/com.github.rssguard.appdata.xml index cb3aac413..1bfeefda5 100644 --- a/resources/desktop/com.github.rssguard.appdata.xml +++ b/resources/desktop/com.github.rssguard.appdata.xml @@ -30,7 +30,7 @@ https://martinrotter.github.io/donate/ - + none diff --git a/src/librssguard/services/greader/greaderserviceroot.cpp b/src/librssguard/services/greader/greaderserviceroot.cpp index 33d7c446f..b09490773 100755 --- a/src/librssguard/services/greader/greaderserviceroot.cpp +++ b/src/librssguard/services/greader/greaderserviceroot.cpp @@ -74,9 +74,10 @@ QList GreaderServiceRoot::obtainNewMessages(Feed* feed, const QHash& stated_messages, const QHash& tagged_messages) { Feed::Status error = Feed::Status::Normal; + QList msgs; if (m_network->intelligentSynchronization()) { - return m_network->getMessagesIntelligently(this, + msgs = m_network->getMessagesIntelligently(this, feed->customId(), stated_messages, tagged_messages, @@ -84,12 +85,15 @@ QList GreaderServiceRoot::obtainNewMessages(Feed* feed, networkProxy()); } else { - return m_network->streamContents(this, feed->customId(), error, networkProxy()); + msgs = m_network->streamContents(this, feed->customId(), error, networkProxy()); } if (error != Feed::Status::NewMessages && error != Feed::Status::Normal) { throw FeedFetchException(error); } + else { + return msgs; + } } bool GreaderServiceRoot::wantsBaggedIdsOfExistingMessages() const {