diff --git a/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.cpp b/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.cpp index c4d725c7d..f78ab73ca 100755 --- a/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.cpp +++ b/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.cpp @@ -46,10 +46,6 @@ InoreaderAccountDetails::InoreaderAccountDetails(QWidget* parent) connect(m_ui.m_btnTestSetup, &QPushButton::clicked, this, &InoreaderAccountDetails::testSetup); connect(m_ui.m_btnRegisterApi, &QPushButton::clicked, this, &InoreaderAccountDetails::registerApi); - m_ui.m_spinLimitMessages->setValue(INOREADER_DEFAULT_BATCH_SIZE); - m_ui.m_spinLimitMessages->setMinimum(INOREADER_MIN_BATCH_SIZE); - m_ui.m_spinLimitMessages->setMaximum(INOREADER_MAX_BATCH_SIZE); - emit m_ui.m_txtUsername->lineEdit()->textChanged(m_ui.m_txtUsername->lineEdit()->text()); emit m_ui.m_txtAppId->lineEdit()->textChanged(m_ui.m_txtAppId->lineEdit()->text()); emit m_ui.m_txtAppKey->lineEdit()->textChanged(m_ui.m_txtAppKey->lineEdit()->text()); diff --git a/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.ui b/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.ui index 578bd0e48..e43edcc20 100755 --- a/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.ui +++ b/src/librssguard/services/inoreader/gui/inoreaderaccountdetails.ui @@ -116,21 +116,8 @@ - - - - - - 140 - 16777215 - - - - message(s) - - - - + + Only download newest X messages per feed @@ -140,6 +127,29 @@ + + + + + 140 + 16777215 + + + + + + + + Qt::Horizontal + + + + 40 + 20 + + + + @@ -195,6 +205,11 @@
labelwithstatus.h
1 + + MessageCountSpinBox + QSpinBox +
messagecountspinbox.h
+
diff --git a/src/librssguard/services/inoreader/inoreadernetworkfactory.cpp b/src/librssguard/services/inoreader/inoreadernetworkfactory.cpp index 8af17f6bd..94fb51f48 100755 --- a/src/librssguard/services/inoreader/inoreadernetworkfactory.cpp +++ b/src/librssguard/services/inoreader/inoreadernetworkfactory.cpp @@ -183,7 +183,9 @@ QList InoreaderNetworkFactory::messages(ServiceRoot* root, const QStrin return QList(); } - target_url += QSL("/") + QUrl::toPercentEncoding(stream_id) + QString("?n=%1").arg(batchSize()); + target_url += QSL("/") + QUrl::toPercentEncoding(stream_id) + QString("?n=%1").arg(batchSize() <= 0 + ? INOREADER_MAX_BATCH_SIZE + : batchSize()); if (downloadOnlyUnreadMessages()) { target_url += QSL("&xt=%1").arg(INOREADER_FULL_STATE_READ); diff --git a/src/librssguard/services/owncloud/gui/owncloudaccountdetails.cpp b/src/librssguard/services/owncloud/gui/owncloudaccountdetails.cpp index 3acb28f0f..d540c38b4 100755 --- a/src/librssguard/services/owncloud/gui/owncloudaccountdetails.cpp +++ b/src/librssguard/services/owncloud/gui/owncloudaccountdetails.cpp @@ -20,9 +20,6 @@ OwnCloudAccountDetails::OwnCloudAccountDetails(QWidget* parent) : QWidget(parent m_ui.m_lblTestResult->setStatus(WidgetWithStatus::StatusType::Information, tr("No test done yet."), tr("Here, results of connection test are shown.")); - m_ui.m_lblLimitMessages->setText( - tr("Limiting number of downloaded messages per feed makes updating of feeds faster but if your feed contains " - "bigger number of messages than specified limit, then some messages might not be downloaded during feed update.")); connect(m_ui.m_spinLimitMessages, static_cast(&QSpinBox::valueChanged), this, [=](int value) { if (value <= 0) { @@ -33,7 +30,6 @@ OwnCloudAccountDetails::OwnCloudAccountDetails(QWidget* parent) : QWidget(parent } }); - GuiUtilities::setLabelAsNotice(*m_ui.m_lblLimitMessages, true); GuiUtilities::setLabelAsNotice(*m_ui.m_lblServerSideUpdateInformation, true); connect(m_ui.m_checkShowPassword, &QCheckBox::toggled, this, &OwnCloudAccountDetails::displayPassword); @@ -42,9 +38,9 @@ OwnCloudAccountDetails::OwnCloudAccountDetails(QWidget* parent) : QWidget(parent connect(m_ui.m_txtUrl->lineEdit(), &BaseLineEdit::textChanged, this, &OwnCloudAccountDetails::onUrlChanged); setTabOrder(m_ui.m_txtUrl->lineEdit(), m_ui.m_checkDownloadOnlyUnreadMessages); - setTabOrder(m_ui.m_checkDownloadOnlyUnreadMessages, m_ui.m_checkServerSideUpdate); - setTabOrder(m_ui.m_checkServerSideUpdate, m_ui.m_spinLimitMessages); - setTabOrder(m_ui.m_spinLimitMessages, m_ui.m_txtUsername->lineEdit()); + setTabOrder(m_ui.m_checkDownloadOnlyUnreadMessages, m_ui.m_spinLimitMessages); + setTabOrder(m_ui.m_spinLimitMessages, m_ui.m_checkServerSideUpdate); + setTabOrder(m_ui.m_checkServerSideUpdate, m_ui.m_txtUsername->lineEdit()); setTabOrder(m_ui.m_txtUsername->lineEdit(), m_ui.m_txtPassword->lineEdit()); setTabOrder(m_ui.m_txtPassword->lineEdit(), m_ui.m_checkShowPassword); setTabOrder(m_ui.m_checkShowPassword, m_ui.m_btnTestSetup); diff --git a/src/librssguard/services/owncloud/gui/owncloudaccountdetails.ui b/src/librssguard/services/owncloud/gui/owncloudaccountdetails.ui index 586a51119..48ce29bee 100755 --- a/src/librssguard/services/owncloud/gui/owncloudaccountdetails.ui +++ b/src/librssguard/services/owncloud/gui/owncloudaccountdetails.ui @@ -6,57 +6,11 @@ 0 0 - 430 - 312 + 433 + 363 - - - - Download only unread messages - - - - - - - Force execution of server-side update when updating feeds from RSS Guard - - - - - - - Only download newest X messages per feed - - - m_spinLimitMessages - - - - - - - - 140 - 16777215 - - - - = unlimited - - - -1 - - - 1000 - - - -1 - - - @@ -74,6 +28,60 @@ + + + + Download only unread messages + + + + + + + + + Only download newest X messages per feed + + + m_spinLimitMessages + + + + + + + + 140 + 16777215 + + + + + + + + Qt::Horizontal + + + + 40 + 20 + + + + + + + + + + + + + true + + + @@ -149,7 +157,7 @@
- + Qt::Vertical @@ -162,23 +170,10 @@ - - - - - - - true - - - - + - - - - true + Force execution of server-side update when updating feeds from RSS Guard @@ -197,6 +192,11 @@
labelwithstatus.h
1 + + MessageCountSpinBox + QSpinBox +
messagecountspinbox.h
+
m_checkDownloadOnlyUnreadMessages diff --git a/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.cpp b/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.cpp index c9f066d95..b2e3dc44d 100644 --- a/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.cpp +++ b/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.cpp @@ -25,7 +25,8 @@ TtRssAccountDetails::TtRssAccountDetails(QWidget* parent) : QWidget(parent) { GuiUtilities::setLabelAsNotice(*m_ui.m_lblServerSideUpdateInformation, true); setTabOrder(m_ui.m_txtUrl->lineEdit(), m_ui.m_checkDownloadOnlyUnreadMessages); - setTabOrder(m_ui.m_checkDownloadOnlyUnreadMessages, m_ui.m_checkServerSideUpdate); + setTabOrder(m_ui.m_checkDownloadOnlyUnreadMessages, m_ui.m_spinLimitMessages); + setTabOrder(m_ui.m_spinLimitMessages, m_ui.m_checkServerSideUpdate); setTabOrder(m_ui.m_checkServerSideUpdate, m_ui.m_txtUsername->lineEdit()); setTabOrder(m_ui.m_txtUsername->lineEdit(), m_ui.m_txtPassword->lineEdit()); setTabOrder(m_ui.m_txtPassword->lineEdit(), m_ui.m_checkShowPassword); diff --git a/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.ui b/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.ui index d014020e6..3868546ea 100644 --- a/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.ui +++ b/src/librssguard/services/tt-rss/gui/ttrssaccountdetails.ui @@ -6,11 +6,24 @@ 0 0 - 429 - 373 + 432 + 480 + + + + Qt::Vertical + + + + 408 + 30 + + + + @@ -36,13 +49,50 @@ + + + + + Only download newest X messages per feed + + + m_spinLimitMessages + + + + + + + + 140 + 16777215 + + + + + + + + Qt::Horizontal + + + + 40 + 20 + + + + + + + Force execution of server-side update when updating feeds from RSS Guard - + @@ -52,7 +102,7 @@ - + Some feeds require authentication, including GMail feeds. BASIC, NTLM-2 and DIGEST-MD5 authentication schemes are supported. @@ -103,7 +153,7 @@ - + Some feeds require authentication, including GMail feeds. BASIC, NTLM-2 and DIGEST-MD5 authentication schemes are supported. @@ -157,38 +207,29 @@
- - - - &Test setup - - - - - - - - 0 - 0 - - - - Qt::RightToLeft - - - - - - Qt::Vertical - - - - 408 - 30 - - - + + + + + &Test setup + + + + + + + + 0 + 0 + + + + Qt::RightToLeft + + + +
@@ -205,6 +246,11 @@
labelwithstatus.h
1 + + MessageCountSpinBox + QSpinBox +
messagecountspinbox.h
+
diff --git a/src/librssguard/services/tt-rss/ttrssserviceroot.cpp b/src/librssguard/services/tt-rss/ttrssserviceroot.cpp index c74d0e7e0..fd3c74df9 100644 --- a/src/librssguard/services/tt-rss/ttrssserviceroot.cpp +++ b/src/librssguard/services/tt-rss/ttrssserviceroot.cpp @@ -216,6 +216,8 @@ QList TtRssServiceRoot::obtainNewMessages(const QList& feeds, bo for (Feed* feed : feeds) { int newly_added_messages = 0; + + // TODO: pokračovat, přidat batchSize() a řešit misto limit. int limit = TTRSS_MAX_MESSAGES; int skip = 0;