From 7e5dab50e671f20133b8fb6c82f60fa4726659f4 Mon Sep 17 00:00:00 2001 From: Martin Rotter Date: Wed, 24 Feb 2021 06:32:25 +0100 Subject: [PATCH] use duck duck go as fallback online favicon source, fixed #363 --- resources/desktop/com.github.rssguard.appdata.xml | 2 +- src/librssguard/network-web/networkfactory.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/desktop/com.github.rssguard.appdata.xml b/resources/desktop/com.github.rssguard.appdata.xml index a31223b89..c267a5089 100644 --- a/resources/desktop/com.github.rssguard.appdata.xml +++ b/resources/desktop/com.github.rssguard.appdata.xml @@ -30,7 +30,7 @@ https://martinrotter.github.io/donate/ - + none diff --git a/src/librssguard/network-web/networkfactory.cpp b/src/librssguard/network-web/networkfactory.cpp index 82ac35c2a..906ea842e 100644 --- a/src/librssguard/network-web/networkfactory.cpp +++ b/src/librssguard/network-web/networkfactory.cpp @@ -176,9 +176,9 @@ QNetworkReply::NetworkError NetworkFactory::downloadIcon(const QList& u host = host.mid(4); } - const QString google_s2_with_url = QString("http://www.google.com/s2/favicons?domain=%1").arg(host); + const QString ddg_icon_service = QString("https://external-content.duckduckgo.com/ip3/%1.ico").arg(host); - network_result = performNetworkOperation(google_s2_with_url, + network_result = performNetworkOperation(ddg_icon_service, timeout, QByteArray(), icon_data, @@ -189,7 +189,7 @@ QNetworkReply::NetworkError NetworkFactory::downloadIcon(const QList& u {}, custom_proxy).first; - if (network_result == QNetworkReply::NoError) { + if (network_result == QNetworkReply::NetworkError::NoError) { QPixmap icon_pixmap; icon_pixmap.loadFromData(icon_data);