From 0cabc5f11291da1814abbf4ce68676b4d338f43a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 20 Jul 2021 22:17:26 -0700 Subject: [PATCH] Read from LoggingPipe returns error --- zellij-server/src/logging_pipe.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/zellij-server/src/logging_pipe.rs b/zellij-server/src/logging_pipe.rs index a2658cf9..f1fae6b8 100644 --- a/zellij-server/src/logging_pipe.rs +++ b/zellij-server/src/logging_pipe.rs @@ -41,13 +41,11 @@ impl LoggingPipe { } impl Read for LoggingPipe { - fn read(&mut self, buf: &mut [u8]) -> std::io::Result { - // NOTE: should we do this? I think if anyone were to chain LoggingPipe and read from it, - // they would see very weird behavior because we drain self.buffer in `flush`. Also, logs would be screwed up. - // Consider removing this code. - let amt = std::cmp::min(buf.len(), self.buffer.len()); - let data: Vec<_> = self.buffer.drain(..amt).collect(); - buf.as_mut().write(&data) + fn read(&mut self, _: &mut [u8]) -> std::io::Result { + Err(std::io::Error::new( + std::io::ErrorKind::Other, + "Can not reed from a LoggingPipe", + )) } }