fix(tabs): do not send release event to inactive tab (#4300)

* fix(ui): switch left/right in multiple-select to prevent confusion

* fix(mouse): do not send release event to inactive pane

* docs(changelog): add PR
This commit is contained in:
Aram Drevekenin 2025-07-17 18:29:04 +02:00 committed by GitHub
parent 9fd7a02023
commit 32d4c7114e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 15 additions and 4 deletions

View file

@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: slow startup on very large caches (https://github.com/zellij-org/zellij/pull/4292)
* fix: don't show popups in the welcome screen (https://github.com/zellij-org/zellij/pull/4294)
* fix: reap processes when using an external clipboard tool (https://github.com/zellij-org/zellij/pull/4298)
* fix: out of bounds mouse release events (https://github.com/zellij-org/zellij/pull/4300)
## [0.42.2] - 2025-04-15
* refactor(terminal): track scroll_region as tuple rather than Option (https://github.com/zellij-org/zellij/pull/4082)

View file

@ -133,10 +133,10 @@ impl App {
}
fn shortcuts_line2_text() -> (&'static str, Text) {
let text = "<r> - break right, <l> - break left";
let text = "<l> - break left, <r> - break right";
let component = Text::new(text)
.color_substring(3, "<r>")
.color_substring(3, "<l>");
.color_substring(3, "<l>")
.color_substring(3, "<r>");
(text, component)
}

View file

@ -4276,7 +4276,17 @@ impl Tab {
self.floating_panes
.stop_moving_pane_with_mouse(event.position);
} else {
self.write_mouse_event_to_active_pane(event, client_id)?;
let active_pane_id = self
.get_active_pane_id(client_id)
.ok_or(anyhow!("Failed to find pane at position"))?;
let pane_id_at_position = self
.get_pane_at(&event.position, false)
.with_context(err_context)?
.ok_or_else(|| anyhow!("Failed to find pane at position"))?
.pid();
if active_pane_id == pane_id_at_position {
self.write_mouse_event_to_active_pane(event, client_id)?;
}
}
if leave_clipboard_message {
Ok(MouseEffect::leave_clipboard_message())