From 3ccc1f39466f35b698bd5ea9b247832dac51cc90 Mon Sep 17 00:00:00 2001
From: a-kenji <aks.kenji@protonmail.com>
Date: Wed, 15 Jun 2022 15:26:52 +0200
Subject: [PATCH] Add/ci enable clippy (#1509)

* fix(clippy): clippy fixes

* add(ci): enable clippy warnings

* chore(fmt): cargo fmt

* disable: failing clippy action

Add `cargo make clippy` in ci
---
 .github/workflows/rust.yml | 12 +++++++-----
 Makefile.toml              |  2 +-
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 280bd131..5e75c2d2 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -72,8 +72,10 @@ jobs:
           ~/.cargo/git
           target
         key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-    - name: Check Lints
-      uses: actions-rs/clippy-check@v1
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        args: --all-features --all-targets
+    - name: Check clippy lints
+      run: cargo make clippy
+    # - name: Check Lints
+    #   uses: actions-rs/clippy-check@v1
+    #   with:
+    #     token: ${{ secrets.GITHUB_TOKEN }}
+    #     args: --all-features --all-targets --deny warnings
diff --git a/Makefile.toml b/Makefile.toml
index 88f3e1ee..16057604 100644
--- a/Makefile.toml
+++ b/Makefile.toml
@@ -92,7 +92,7 @@ args = [
 
 # Simple clippy tweak
 [tasks.clippy]
-args = ["clippy", "--all-targets","--all-features","--", "@@split(CARGO_MAKE_TASK_ARGS,;)"]
+args = ["clippy", "--all-targets","--all-features","--","--deny","warnings", "@@split(CARGO_MAKE_TASK_ARGS,;)"]
 
 # Release building and installing Zellij
 [tasks.install]