From 522790984699b36ca197749d11ad638303a072f7 Mon Sep 17 00:00:00 2001 From: Thomas Linford Date: Thu, 12 Jan 2023 18:38:12 +0100 Subject: [PATCH] fix(mouse): selection not ending on mouse release with copy_on_select set to false (#2086) --- zellij-server/src/tab/mod.rs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/zellij-server/src/tab/mod.rs b/zellij-server/src/tab/mod.rs index 0cf3a697..036fbd68 100644 --- a/zellij-server/src/tab/mod.rs +++ b/zellij-server/src/tab/mod.rs @@ -2371,17 +2371,20 @@ impl Tab { } else { let relative_position = active_pane.relative_position(position); if let PaneId::Terminal(_) = active_pane.pid() { - if selecting && copy_on_release { + if selecting { active_pane.end_selection(&relative_position, client_id); - let selected_text = active_pane.get_selected_text(); - active_pane.reset_selection(); + if copy_on_release { + let selected_text = active_pane.get_selected_text(); + active_pane.reset_selection(); - if let Some(selected_text) = selected_text { - self.write_selection_to_clipboard(&selected_text) - .with_context(err_context)?; + if let Some(selected_text) = selected_text { + self.write_selection_to_clipboard(&selected_text) + .with_context(err_context)?; + } } } } else { + // notify the release event to a plugin pane, should be renamed active_pane.end_selection(&relative_position, client_id); }