From 59d753dc2f48e591aedb59e0b3e4710516c7be42 Mon Sep 17 00:00:00 2001 From: har7an <99636919+har7an@users.noreply.github.com> Date: Thu, 23 Jun 2022 19:41:57 +0000 Subject: [PATCH] fix: Make key order consistent (#1539) The order of the "arrow" keys is always left/down/up/right, make the keybindings for the Scroll mode align with this ordering. --- .../zellij__tests__e2e__cases__scrolling_inside_a_pane.snap | 2 +- zellij-utils/src/input/mod.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tests/e2e/snapshots/zellij__tests__e2e__cases__scrolling_inside_a_pane.snap b/src/tests/e2e/snapshots/zellij__tests__e2e__cases__scrolling_inside_a_pane.snap index 422a5616..0d8db2d4 100644 --- a/src/tests/e2e/snapshots/zellij__tests__e2e__cases__scrolling_inside_a_pane.snap +++ b/src/tests/e2e/snapshots/zellij__tests__e2e__cases__scrolling_inside_a_pane.snap @@ -26,4 +26,4 @@ expression: last_snapshot │ ││line19 00000000000000000000000000000000000000000000000000█│ └──────────────────────────────────────────────────────────┘└──────────────────────────────────────────────────────────┘ Ctrl + LOCK 

PANE  TAB  RESIZE  MOVE  SCROLL  SESSION  QUIT  - <↓↑> Scroll / Scroll / Scroll / Edit / Select pane + <↓↑> Scroll / Scroll / Scroll / Edit / Select pane diff --git a/zellij-utils/src/input/mod.rs b/zellij-utils/src/input/mod.rs index ed88b62d..807c87c9 100644 --- a/zellij-utils/src/input/mod.rs +++ b/zellij-utils/src/input/mod.rs @@ -53,8 +53,8 @@ pub fn get_mode_info(mode: InputMode, style: Style, capabilities: PluginCapabili ], InputMode::Scroll => vec![ ("↓↑".to_string(), "Scroll".to_string()), - ("PgUp/PgDn".to_string(), "Scroll Page".to_string()), - ("u/d".to_string(), "Scroll Half Page".to_string()), + ("PgDn/PgUp".to_string(), "Scroll Page".to_string()), + ("d/u".to_string(), "Scroll Half Page".to_string()), ( "e".to_string(), "Edit Scrollback in Default Editor".to_string(),