From aa8da0b14232ca20ff6438bbd2ba9477888e1db1 Mon Sep 17 00:00:00 2001 From: henil Date: Mon, 25 Jan 2021 23:06:24 +0530 Subject: [PATCH 1/5] Add initial issue template and CONTRIBUTING.md --- .github/ISSUE_TEMPLATE/blank_issue.md | 4 ++++ .github/ISSUE_TEMPLATE/bug_report.md | 5 +++++ .github/ISSUE_TEMPLATE/config.yml | 1 + CONTRIBUTING.md | 32 +++++++++++++++++++++++++++ 4 files changed, 42 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/blank_issue.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/config.yml create mode 100644 CONTRIBUTING.md diff --git a/.github/ISSUE_TEMPLATE/blank_issue.md b/.github/ISSUE_TEMPLATE/blank_issue.md new file mode 100644 index 00000000..9aef3ebe --- /dev/null +++ b/.github/ISSUE_TEMPLATE/blank_issue.md @@ -0,0 +1,4 @@ +--- +name: Blank Issue +about: Create a blank issue. +--- diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..5e6553c9 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,5 @@ +--- +name: Bug Report +about: Create a bug report +labels: bug +--- diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 00000000..0086358d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1 @@ +blank_issues_enabled: true diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 00000000..fa19fd19 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,32 @@ +# Contributing to Mosaic + +Thanks for considering to contribute to mosaic! + +Before contributing please read our [Code of Conduct](CODE_OF_CONDUCT.md) which +all contributors are expected to adhere to. + +## Add an entry to the changelog + +If your contribution changes the behavior of `mosaic` (as opposed to a typo-fix +in the documentation), please update the [`CHANGELOG.md`](CHANGELOG.md) file +and describe your changes. This makes the release process much easier and +therefore helps to get your changes into a new `mosaic` release faster. + +The top of the `CHANGELOG` contains a *"unreleased"* section with a few +subsections (Features, Bugfixes, …). Please add your entry to the subsection +that best describes your change. + +Entries follow this format: +``` +- Short description of what has been changed, see #123 (@user) +``` +Here, `#123` is the number of the original issue and/or your pull request. +Please replace `@user` by your GitHub username. + +## Lacking API for plugin in mosaic + +If you have a plugin idea, but mosaic still doesn't have API required to make +the plugin consider opening [an issue][plugin-issue] and describing your +requirements. + +[plugin-issue]: https://github.com/mosaic-org/mosaic/issues/new?assignees=&labels=plugin%20system From c906a8b2fa8a2f2ff95ad50a6496cc0df0b8989d Mon Sep 17 00:00:00 2001 From: henil Date: Thu, 4 Feb 2021 14:51:11 +0530 Subject: [PATCH 2/5] removed CHANGELOG for now and added some more details --- CONTRIBUTING.md | 72 +++++++++++++++++++++++++++++++++++++------------ README.md | 4 +++ 2 files changed, 59 insertions(+), 17 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fa19fd19..e5d790c4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,31 +2,69 @@ Thanks for considering to contribute to mosaic! +**First**: if you're unsure or afraid of anything, just ask on our +[Discord server](discord-invite-link) or submit the issue or pull request anyway. +You won't be yelled at for giving it your best effort. The worst that can happen +is that you'll be politely asked to change something. We appreciate any sort +of contributions, and don't want a wall of rules to get in the way of that. + +# Code of Conduct + Before contributing please read our [Code of Conduct](CODE_OF_CONDUCT.md) which all contributors are expected to adhere to. -## Add an entry to the changelog +## Looking for something to work on? -If your contribution changes the behavior of `mosaic` (as opposed to a typo-fix -in the documentation), please update the [`CHANGELOG.md`](CHANGELOG.md) file -and describe your changes. This makes the release process much easier and -therefore helps to get your changes into a new `mosaic` release faster. +If you are new contributor to `Mosaic` going through [beginners](good-first-issue) +should be a good start or you can join our public +[Discord server](discord-invite-link), we would be happy to help +finding something interesting to work on and guide through. -The top of the `CHANGELOG` contains a *"unreleased"* section with a few -subsections (Features, Bugfixes, …). Please add your entry to the subsection -that best describes your change. +[discord-invite-link]: https://discord.gg/feHDHahHCz +[good-first-issue]: https://github.com/mosaic-org/mosaic/labels/good%20first%20issue -Entries follow this format: -``` -- Short description of what has been changed, see #123 (@user) -``` -Here, `#123` is the number of the original issue and/or your pull request. -Please replace `@user` by your GitHub username. +## Filing Issues -## Lacking API for plugin in mosaic +Bugs and enhancement suggestions are tracked as GitHub issues. + +#### Lacking API for plugin in mosaic? If you have a plugin idea, but mosaic still doesn't have API required to make -the plugin consider opening [an issue][plugin-issue] and describing your -requirements. +the plugin consider opening [an issue][plugin-issue] and describing your requirements. [plugin-issue]: https://github.com/mosaic-org/mosaic/issues/new?assignees=&labels=plugin%20system + +#### How Do I Submit A (Good) Bug Report? + +After you've determined which repository your bug is related to and that the +issue is still present in the latest version of the master branch, create an +issue on that repository and provide the following information: + +- Use a **clear and descriptive title** for the issue to identify the problem. +- Explain which **behavior you expected** to see instead and why. +- Describe the exact **steps to reproduce the problem** in as many details as necessary. +- When providing code samples, please use [code blocks](code-blocks). + +#### How Do I Submit A (Good) Enhancement Suggestion? + +Instructions are similar to those for bug reports. Please provide the following +information: + +- Use a **clear and descriptive title** for the issue to identify the suggestion. +- Provide a **description of the suggested enhancement** in as many details as necessary. +- When providing code samples, please use [code blocks](code-blocks). + +[code-blocks]: https://help.github.com/articles/creating-and-highlighting-code-blocks/ + +## Submitting Pull Requests + +Instructions are similar to those for bug reports. Please provide the following information: + +- If this is not a trivial fix, consider **creating an issue to discuss first** and **later link to it from the PR**. +- Use a **clear and descriptive title** for the pull request. +- Provide a **description of the changes** in as many details as necessary. + +Before submitting your pull request, also make sure that the following conditions are met: + +- Your new code **adheres to the code style** through running `cargo fmt`. +- Your new code **passes all existing and new tests** through running `cargo test`. diff --git a/README.md b/README.md index 7cd63b9f..4e6c9fc8 100644 --- a/README.md +++ b/README.md @@ -100,6 +100,10 @@ This section contains an ever-changing list of the major features that are eithe * Built in support for portable workspaces across machines, projects and teams: imagine being able to include a configuration file with your project that would include all the layouts and plugins that would best help new developers getting onboarded. Including all the shortcuts, customized panes and help-message hints triggered by things such as opening a file, entering a folder or running a command. How about being able to log into a new server or container, start mosaic with a URL of a git repository including your favorite configuration and plugins, and working with it as if you were on your own machine? * Support for multiple terminal windows across screens: Why limit yourself to one terminal window? Mosaic would allow you to transfer panes, view powerlines, get alerts and control your workspace from different windows by having them all belong to the same session. +# Contributing + +Take a look at [`Contributing.md`](CONTRIBUTING.md) guide. + # License MIT From 08544615199f3edf4bc2c8ae85ad1e17db34d23f Mon Sep 17 00:00:00 2001 From: henil Date: Thu, 4 Feb 2021 18:48:47 +0530 Subject: [PATCH 3/5] fix links --- CONTRIBUTING.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e5d790c4..fe493c52 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -3,7 +3,7 @@ Thanks for considering to contribute to mosaic! **First**: if you're unsure or afraid of anything, just ask on our -[Discord server](discord-invite-link) or submit the issue or pull request anyway. +[Discord server][discord-invite-link] or submit the issue or pull request anyway. You won't be yelled at for giving it your best effort. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that. @@ -15,9 +15,9 @@ all contributors are expected to adhere to. ## Looking for something to work on? -If you are new contributor to `Mosaic` going through [beginners](good-first-issue) +If you are new contributor to `Mosaic` going through [beginners][good-first-issue] should be a good start or you can join our public -[Discord server](discord-invite-link), we would be happy to help +[Discord server][discord-invite-link], we would be happy to help finding something interesting to work on and guide through. [discord-invite-link]: https://discord.gg/feHDHahHCz @@ -43,7 +43,7 @@ issue on that repository and provide the following information: - Use a **clear and descriptive title** for the issue to identify the problem. - Explain which **behavior you expected** to see instead and why. - Describe the exact **steps to reproduce the problem** in as many details as necessary. -- When providing code samples, please use [code blocks](code-blocks). +- When providing code samples, please use [code blocks][code-blocks]. #### How Do I Submit A (Good) Enhancement Suggestion? @@ -52,7 +52,7 @@ information: - Use a **clear and descriptive title** for the issue to identify the suggestion. - Provide a **description of the suggested enhancement** in as many details as necessary. -- When providing code samples, please use [code blocks](code-blocks). +- When providing code samples, please use [code blocks][code-blocks]. [code-blocks]: https://help.github.com/articles/creating-and-highlighting-code-blocks/ From 81989ede17407f51fdf4f36fb2269e5d7204fbf1 Mon Sep 17 00:00:00 2001 From: henil Date: Thu, 4 Feb 2021 18:51:00 +0530 Subject: [PATCH 4/5] change heading level --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fe493c52..db81f0ae 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -27,14 +27,14 @@ finding something interesting to work on and guide through. Bugs and enhancement suggestions are tracked as GitHub issues. -#### Lacking API for plugin in mosaic? +### Lacking API for plugin in mosaic? If you have a plugin idea, but mosaic still doesn't have API required to make the plugin consider opening [an issue][plugin-issue] and describing your requirements. [plugin-issue]: https://github.com/mosaic-org/mosaic/issues/new?assignees=&labels=plugin%20system -#### How Do I Submit A (Good) Bug Report? +### How Do I Submit A (Good) Bug Report? After you've determined which repository your bug is related to and that the issue is still present in the latest version of the master branch, create an @@ -45,7 +45,7 @@ issue on that repository and provide the following information: - Describe the exact **steps to reproduce the problem** in as many details as necessary. - When providing code samples, please use [code blocks][code-blocks]. -#### How Do I Submit A (Good) Enhancement Suggestion? +### How Do I Submit A (Good) Enhancement Suggestion? Instructions are similar to those for bug reports. Please provide the following information: From b1006b9f4dd31533dac8cfad1bc97e7f69dd15fc Mon Sep 17 00:00:00 2001 From: henil Date: Fri, 5 Feb 2021 21:03:24 +0530 Subject: [PATCH 5/5] Follow Conventional commits where necessary --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index db81f0ae..51598ddf 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -62,6 +62,8 @@ Instructions are similar to those for bug reports. Please provide the following - If this is not a trivial fix, consider **creating an issue to discuss first** and **later link to it from the PR**. - Use a **clear and descriptive title** for the pull request. + - Follow [Conventional Commit specification](https://www.conventionalcommits.org/en/v1.0.0/) +where sufficiently large or impactful change is made. - Provide a **description of the changes** in as many details as necessary. Before submitting your pull request, also make sure that the following conditions are met: