From e1e1f2104353ca021fe9b5261314ab6248c3b77c Mon Sep 17 00:00:00 2001 From: Aram Drevekenin Date: Wed, 24 Mar 2021 10:58:50 +0100 Subject: [PATCH] fix(render): various rendering issues (#238) --- src/client/panes/terminal_pane.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/client/panes/terminal_pane.rs b/src/client/panes/terminal_pane.rs index 9fa70d11..f0b15e50 100644 --- a/src/client/panes/terminal_pane.rs +++ b/src/client/panes/terminal_pane.rs @@ -188,7 +188,14 @@ impl Pane for TerminalPane { self.max_height } fn render(&mut self) -> Option { - if self.should_render || cfg!(test) { + // FIXME: + // the below conditional is commented out because it causes several bugs: + // 1. When panes are resized or tabs are switched the previous contents of the screen stick + // around + // 2. When there are wide characters in a pane, since we don't yet handle them properly, + // the spill over to the pane to the right + // if self.should_render || cfg!(test) { + if true { let mut vte_output = String::new(); let buffer_lines = &self.read_buffer_as_lines(); let display_cols = self.get_columns();