* basic about screen
* work
* finish implementing about plugin except theme spec
* show about plugin only on first version run
* some cleanups and do the right thing with open/xdg-open
* refactor: make ui framework
* refactor: remove old stuff
* refactor: about plugin
* style(fmt): rustfmt
* chore(repo): about plugin asset
* fix tests
* style(fmt): rustfmt!!
* Implement initial structs from spec
* kdl configuration unmarshalling
* typo text styling
* remove is_selected toggle
* incorporate new status bar ui into theming
* improve test coverage of config behavior
* tab bar correction
* correct also compact bar
* remove spacing between table columns
* refactor table styling
* use text_unselected.emphasis_1 for keygroup sep
* fix tab bar more text
* repair field flattening for theme
* remove extra styling KDL node
* update tests
* updated selected text conversion
* padding for header bar
* minor corrections for existing themes
* background handling
* compact bar corrections
* properly handle opaque method to activate background
* update newer plugins to use styling struct
* correct omission of selected state
* fix: bold typeface for text elements
* fix: fg -> white for list_unselected conversion
* fix: emphasis and opacity handling for nested_list
* correct stylings in the session-manager
* fix emphases translation for table component
* correct emphasis for run instructions
* correct frame_highlight translation for old themes
* provide missing implementation of frame_highlight
* fencepost emphasis color names
* Set a pseudo-None for frame_unselected in old theme conversion
* correct alternating bg for simplified-ui
* update snapshots
* fix inner text padding and errorneous snapshots
* suppress warning about deprecated usage of palette
* remove unused import
* feat(plugins): API to change floating pane coordinates (#3958)
* basic functionality through the cli
* added to plugin api
* add display area and viewport size to TabInfo
* fix tests and add new one
* some cleanups
* refactor: extract pane_id parsing logic
* style(fmt): rustfmt
* docs(changelog): floating pane coordinate chagne API
* fix(tiled-panes): opening panes from the cli (#3963)
* feat(plugins): add `PastedText` Event (#3962)
* working with text paste
* handle utf8 conversion error
* feat(plugins): add PastedText Event
* docs(changelog): plugins pasted text event
* black for table opaque background
* properly apply opacity to table
* correct padding for explicit width ribbons
* feat(plugins): Allow opening panes near plugin (#3966)
* added command + terminal variants
* added editor variant
* style(fmt): rustfmt
* docs(changelog): plugin apis to open panes near plugin
* feat(plugins): send info about $EDITOR and $SHELL (#3971)
* feat(plugins): send info about $EDITOR and $SHELL
* fix(e2e): snapshot update
* docs(changelog): plugin editor and shell info
* fix(floating-panes): when changing coordinates, if a pane is not floating - make it floating (#3972)
* fix(panes): when changing floating pane coordinates, if the pane is not floating, float it
* style(fmt): rustfmt
* docs(changelog): floating pane coordinate fix
* fix(break-pane): strip logical position when inserting pane to new tab (#3973)
* docs(changelog): logical position fix
* Optional frame_unselected theme
* fixture with correct width to account for arrow padding
* update snapshot and rustfmt
---------
Co-authored-by: Aram Drevekenin <aram@poor.dev>
* basic functionality through the cli
* added to plugin api
* add display area and viewport size to TabInfo
* fix tests and add new one
* some cleanups
* refactor: extract pane_id parsing logic
* style(fmt): rustfmt
* work
* tests and initial notes for refactoring
* refactor(stacked-panes): break out pane
* vertical functionality working with a single stack
* refactor: break out pane from stack
* fix: properly support multiple stacks in tab
* combining multiple stacks vertically
* vertical resizing working for all cases
* base functionality and tests
* some UX tweaking
* final functionality for directionless stacked increase
* some cleanups
* moar cleanups
* refactor: stacked resize
* fix: issue where resizing stacked geoms to 0 would cause them to overflow afterwards
* fix: handle uneven stacking
* functionality with tombstones
* new open new pane functionality
* match decrease increment behavior to increase one and fix some issues
* set fullscreen if maxed out
* allow splitting stacks
* fix tests mostly by parameterizing stacked_resize
* add tests
* some cleanups
* style(fmt): rustfmt
* add to config
* disable ci cache
* is_stacked => stacked
* docs(config): remove duplication
From
https://sw.kovidgoyal.net/kitty/keyboard-protocol/#progressive-enhancement:
> The escape code for requesting enhancements is:
> CSI = flags ; mode u
That means it can be *set* with CSI =, not just pushed/popped onto the
stack with CSI < and CSI >.
This is important because otherwise zellij would interpret this as
restore_cursor_position, which would move the cursor.
This would be hit by the next fish-shell release, which sends CSI = 5
u and CSI = 0 u to enable/disable the kitty keyboard enhancements
unconditionally,
so if you used any program that saved the cursor position it would
constantly move your cursor back on every prompt.
Fixes#3852
* Switch to multi-valued mouse buttons and stub for remembering old mouse button state
* Stubs for passing all mouse events from user-facing terminal to server
side terminal(s) in, including protobuf.
Removed "held" mouse actions.
Currently commented out calls to left/middle/right-click/release --
need to fix this though, as selection/copy-paste are broken too.
cargo build/test/run works OK.
cargo xtask build/test/run fails, unable to find crate input::mouse.
* 'cargo xtask build' working using refactored functions.
* fix(plugins): various cwd fixes (#3545)
* fix(plugins): various cwd fixes
* fix tests
* docs(changelog): floating_panes cwd fix
* feat(plugins): rerun_command_pane API (#3546)
* feat(plugins): rerun_command_pane API
* fix tests
* docs(changelog): rerun command pane plugin API
* feat(plugins): command pane re-run event (#3553)
* docs(changelog): CommandPaneReRun plugin event
* feat(ux): first run setup-wizard (#3556)
* separate saved/runtime structure, kind of working
* serializing config
* work
* work
* save config through the configuration screen
* work
* startup wizard
* style(code): cleanups
* fix(session): reload config from disk when switching sessions
* style(fmt): rustfmt
* fix(config): propagate cli config options to screen
* style(fmt): rustfmt
* docs(changelog): first run setup wizard
* feat(ux): reload config at runtime (#3558)
* feat(ux): reload config at runtime
* style(fmt): rustfmt
* docs(changelog): reload config at runtime
* feat(ux): change themes at runtime (#3559)
* docs(changelog): change themes at runtime
* feat(plugins): API to temporarily bind keys to send a message to a specific plugin id (#3561)
* docs(changelog): message to specific plugins API
* feat(ux): reload config options at runtime (#3564)
* change simplified_ui at runtime
* change default_shell at runtime
* change pane_frames (from config) at runtime
* all other options
* some refactoring
* style(fmt): rustfmt
* docs(changelog): reload config options at runtime
* feat(plugins): add plugin APIs to affect other panes (#3576)
* resize_pane_with_id and close_pane_with_id
* focus_pane_with_id and edit_scrollback_for_pane_with_id
* write_to_pane_id and write_chars_to_pane_id
* lots more commands
* style(fmt): rustfmt
* docs(changelog): new plugin apis
* docs(readme): update sponsors
* feat(plugins): APIs to break multiple panes into a new tab or an existing tab (#3610)
* feat(plugins): break multiple panes to a new tab
* fix(layouts): properly ignore run instructions when breaking panes
* feat(plugins): break multiple panes to existing tab
* feat(apis): allow these methods to also specify whether they want focus changed to the tab
* various fixes
* allow specifying name for the new tab when breaking out panes
* style(fmt): rustfmt
* docs(changelog): break multiple panes APIs
* feat(config): allow loading background plugins on startup (#3616)
* remove old partial implementation
* feat(plugins): allow loading background plugins on startup
* add e2e test
* update config
* udpate config merging
* style(fmt): rustfmt
* docs(changelog): background plugins
* feat(ui): built-in plugin manager (#3633)
* add plugin list to session info
* feat(plugins): new_plugin and reload_plugin API commands
* feat(plugins): built-in plugin manager
* style(fmt): rustfmt
* update plugins
* docs(changelog): plugin-manager
* fix(resurrection): various serialization issues (#3636)
* fix(serialization): use kdl-rs for serialization
* style(fmt): remove dead code
* tests(serialization): update snapshots
* style(fmt): rustfmt
* docs(changelog): resurrection fixes
* fix(http): web requests (#3643)
* docs(changelog): http fix
* feat(cli): make --layout idempotent(-ish) (#3650)
* feat(cli): if inside a session, apply --layout to the session
* fix(screen): some focusing races when switching tab focus
* style(fmt): rustfmt
* docs(changelog): improve --layout flag
* fix(plugins): handle race when setting plugin selectable (#3651)
* docs(changelog): plugin selectable race
* feat(cli): show CACHE_DIR in `zellij setup --check` (#3652)
* docs(changelog): add cache dir to setup
* fix(ui): various pane name fixes (#3653)
* docs(changelog): pane name fixes
* fix(ux): only damage the relevant swap layout layer when resizing panes (#3654)
* docs(changelog): swap layout damage fix
* fix(ui): set background color for UI components according to theme (#3658)
* docs(changelog): ui component fix
* fix(tab): recover from crash when resizing panes (#3659)
* chore(git): Add plugin’s issue templates (#3621)
Co-authored-by: Zykino <3809938+Zykino@users.noreply.github.com>
* fix(ux): make sure esc works as expected in unlock-first (#3660)
* fix(ux): make sure esc always drops us back to base mode
* fix(ux): add locked
* fix(plugins): handle concurrent http downloads (#3664)
* docs(changelog): concurrent http plugin downloads
* fix(plugins): various plugin api and other fixes (#3665)
* fix(plugins): do not allow focusing an unselectable pane
* fix(folders): make sure config and cache folders exist on app start
* docs(changelog): plugin fixes
* fix(plugins): force use curl system lib on macOS (#3668)
* docs(changelog): fix http requests for macos
* fix(resurrection): plugin alias resurrection (#3673)
* fix(resurrection): make sure plugin aliases are serialized properly
* style(fmt): rustfmt
* docs(changelog): resurrection alias fix
* fix(plugins): do not allow attaching to the same session (#3674)
* docs(changelog): fix plugins attaching to same session
* fix(plugins): allow switching to a new session with cwd without specifying a layout (#3676)
* docs(changelog): switch_session_with_cwd plugin api
* fix(config): watch/update config given with --config when appropriate (#3678)
* docs(changelog): reload config flag fix
* feat(plugins): rebind keys api (#3680)
* feat(plugins): add API to explicitly unbind/rebind specific keys in specific modes
* style(fmt): rustfmt
* docs(changelog): rebind keys plugin api
* fix(client): repeat retry screen instruction (#3570)
* docs(changelog): sixel fix
* feat(ui): rebind keys UI (#3686)
* rebind action working
* functional ui
* responsive ui
* some refactoring
* properly reset ui state
* minor fixes
* style(fmt): rustfmt
* style(fmt): remove dead code
* chore(deps): update to Wasmtime 21.0.2 (#3685)
This fixes a race condition which causes occasional crashes and may
enable a sandbox escape:
<https://github.com/bytecodealliance/wasmtime/security/advisories/GHSA-7qmx-3fpx-r45m>
* docs(changelog): wasmtime patch upgrade
* feat(plugins): add API to list clients, their focused panes and running commands/plugins (#3687)
* fix(list-clients): properly show client info after a tab was closed
* feat(plugins): add API to list clients, their focused panes and running commands/plugins
* style(fmt): rustfmt
* docs(changelog): list-clients plugin api
* docs(changelog): rebind keys UI
* feat(ui): bring back fullscreen indication (#3688)
* feat(ui): bring back fullscreen indication
* fix e2e tests
* docs(changelog): bring back fullscreen indication
* fix(ux): new interface/configuration touch-ups (#3691)
* fix(ui): copy to clipboard in new ui
* fix(ux): allow navigating out of scrolled pane
* style(fmt): rustfmt
* docs(changelog): ui touch-ups
* fix(plugins): rebind insert (#3692)
* fix(tab): recover from closing a pane outside the viewport
* remap insert in plugin manager
* fix(plugins): remap insert key
* style(fmt): rustfmt
* docs(changelog): insert rebind
* fix(plugins): make sure to always render on first resize (#3693)
* fix(plugins): make sure to always render on first resize
* style(fmt): rustfmt
* fix tests
* docs(changelog): plugins first-render fix
* fix(terminal): recover from partial line drop (#3695)
* docs(changelog): grid fix
* fix(configuration): leave notification up when base mode changes (#3696)
* fix(layouts): suspend commands in remote layouts (#3697)
* fix(layouts): suspend commands in remote layouts
* style(fmt): rustfmt
* docs(changelog): suspend commands in remote layouts
* feat(plugins): add configurable black background for ui components (#3681)
* feat(plugins): add transparent background for text and nested_list
* chore: fix formatting issue
* feat: invert flag behaviour
* feat: implement bg_black handling for table cells
* fix: order of selected and bg_black in protocol
* chore: rename from bg_black to opaque
* fix: explicit selected, if opaque and selected for text
* chore: fix formatting issues
* feat: opaque tab-bar
* feat: opaque session-manager bars
* feat: opaque ribbon in plugin manager
* feat: opaque one-line ui
* feat: opaque tab-bar in configuration plugin
* style(fmt): various cleanups (#3698)
* fix(configuration): rounding error in ui
* style(fmt): remove warnings
* style(fmt): rustfmt
* docs(changelog): ui components bg fix
* feat(theme): add theme ao (#3478)
* feat(themes): add atelier sulphurpool theme (#3596)
* feat(themes): added ayu mirage, light, and dark themes (#3567)
Co-authored-by: Evan Lauer <evanlauer@u.boisestate.edu>
* feat(themes): add Vesper theme (#3443)
* feat(themes): add night-owl theme (#3393)
Co-authored-by: Bruno Mesquita <bmesquita@atlassian.com>
* feat: add iceberg dark/light themes (#3323)
* theme: add onedark theme to the available themes (#3313)
Onedark is a popular theme from Atom text editor.
I've used these sources as the reference for implementing the theme in zellij.
https://github.com/joshdick/onedark.vimhttps://www.figma.com/community/file/1137445418485757476/atom-one-dark-color-palette
* feat(themes): add basic ANSI theme (#3308)
* fix(theme): fix for gruvbox light and dark (#3255)
the previous themes do not have the correct colors and aren't great
for the eyes. when selecting e.g. to copy text, it uses
red for light theme and the same bg for dark theme.
the previous light theme is not even a light theme so I also
fixed that as well.
Signed-off-by: Soc Virnyl Estela <contact@uncomfyhalomacro.pl>
* feat(themes): create lucario.kdl (#3030)
* docs(changelog): new themes
* style(fmt): remove warnings (#3701)
* fix: (tabs) move to next tab if moving to next pane from fullscreen pane (#3498)
Co-authored-by: Vasilis Manolopoulos <vmanolop@gmail.comh>
* docs(changelog): MoveFocusOrTab fullscreen awareness
* docs(readme): add https to curl download
* fix(ux): configuration fixes (#3713)
* fix(startup): try create config folder if it doesn't exist
* fix(configuration): tab bar ui
* fix(configuration): rebind ctrl-s to ctrl-a
* fix(configuration): remove extra rebinding leaders screen
* docs(changelog): configuration fixes
* fix(ux): forward keys to pane in locked mode and base mode rather than hard-coded normal mode (#3715)
* fix(keybindings): only forward clear keys in locked mode and default mode
* style(fmt): rustfmt
* docs(changelog): base mode keybindings fix
* chore(release): v0.41.0
* HOTFIX: default plugins generic compilation issue
* HOTFIX: patch version
* chore(release): v0.41.1
* chore(repo): bump development version
* fix(input): remove support for extra modifiers (#3725)
* docs(changelog): kitty input fix
* fix(input): refix ctrl-j (#3746)
* fix(input): refix ctrl-j
* fix e2e tests
* docs(changelog): refix ctrl-j
* fix(plugins): cwd and usability fixes (#3749)
* fix(plugins): maintain cwd between plugin reloads
* fix(plugin-manager): default to loading plugins in the foreground and allow sending space in configuration
* docs(changelog): plugin fixes
* fix(output-buffer): truncate grid height when not rendering it fully (#3750)
* fix(output-buffer): truncate grid height when not rendering it fully
* also fix for cases where the changed lines are not contiguous
* docs(changelog): output-buffer fix
* fix(tabs): maintain event order for MoveTab (#3758)
* fix(tabs): maintain event order for MoveTab
* style(fmt): rustfmt
* docs(changelog): event ordering fix
* fix(plugins): do not open extra instances of aliases (#3759)
* docs(changelog): do not duplicate built-in plugins
* fix(terminal): reset kitty keyboard support when resetting terminal state (#3760)
* docs(changelog): kitty reset fix
* fix(config): crash if unable to watch config folder (#3761)
* docs(changelog): config dir crash fix
* fix(statup): slow startup on some occasions (#3767)
* add debug logs
* add log messages
* some more logs and possible fix?
* remove logs
* style(fmt): rustfmt
* remove comment
* docs(changelog): occasional slow startup fix
* fix(panes): handle various invalid state situations (#3776)
* docs(changelog): invalid state handling
* chore: add vendored_curl feature (#3766)
* docs(changelog): vendored curl option
* fix(ux): change plugin manager shortcut (#3779)
* docs(changelog): shortcut change
* fix(screen): send PaneClosed event to plugins also when closing the whole tab (#3781)
* docs(changelog): pane-closed event
* feat(plugins): add /cache folder (#3787)
* feat(plugins): add /cache folder
* style(fmt): rustfmt
* docs(changelog): plugin cache folder
* docs(changelog): plugin cache folder url
* chore(package): vendor common_path (#3780)
* vendoring common_path
* add original license to common_path
* Clarify license scope
* refactor: remove rand dependency
---------
Co-authored-by: Aram Drevekenin <aram@poor.dev>
* docs(changelog): vendor common_path
* fix(plugins): derive hash and ord for PaneId (#3790)
* docs(changelog): derive hash and ord for paneid
* style(fmt): remove warnings
* chore(version): set patch version
* chore(release): v0.41.2
* chore(repo): bump development version
* chore(repo): fix typo in lock file
* fix(plugins): properly focus pane after tab was closed (#3797)
* fix(plugins): properly focus pane after tab was closed
* style(fmt): rustfmt
* docs(changelog): focus_pane_with_id fix
* fix(plugins): properly pad UI elements when they have a background (#3806)
* fix(plugins): mark selected background up until component width
* style(fmt): rustfmt
* docs(changelog): ui component padding
* feat(plugins): allow changing the plugin's `/host` folder (under a new permission) (#3827)
* working without notifying plugins
* permissions and events
* cleanups and formatting
* style(fmt): rustfmt
* docs(changelog): allow plugins to change host folder
* chore(repo): add funding.json (#3838)
* chore(repo): add funding.json
* update funding json url
* fix(plugins): do not detach if using a slash in a session name (#3839)
* docs(changelog): slash detach fix
* fix(plugins): properly focus plugin after it was hidden (#3841)
* docs(changelog): plugin hidden focus fix
* fix(screen): off by 1 error when focusing layout tab (#3844)
* docs(changelog): layout tab focus fix
* fix(multiuser): properly clear fake cursors (#3845)
* docs(changelog): multiplayer cursor fix
* feat(ux): pin floating panes (#3876)
* working
* ui indication
* add keybinding
* add to plugin panes
* fix with multiple cursors
* toggle with the mouse
* fix e2e tests and add new one
* some cleanups
* add to layouts
* make mouse click more lenient
* allow setting a new floating pane as pinned
* make toggle work throughthe command line
* add to plugin api
* get tests to pass
* style(fmt): rustfmt
* docs(changelog): pin floating panes
* fix(layout-applier): logical index pane sorting (#3893)
* initial draft
* working with floating panes as well
* use the same method for applying an initial layout to tiled panes
* some refactoring
* all code paths working with logical positioning fallback!
* get tests to compile
* get e2e tests to pass
* fix e2e remote runner
* breadth-first layout sorting
* fix some bugs
* style(fmt): rustfmt
* style(fmt): remove comments
* docs(changelog): logical index pane sorting
* fix(terminal): mode 2026 feature detection response (#3884)
The response to the 2026 mode query was missing a `?` character.
The response should be of the format `CSI ? 2026 ; N $ y` where N can
be any value in the range 0-4 inclusive.
References:
https://gist.github.com/christianparpart/d8a62cc1ab659194337d73e399004036https://vt100.net/docs/vt510-rm/DECRPM.html
* docs(changelog): synchronized rendering query response
* fix(terminal): cursor overflow (#3894)
* docs(changelog): cursor overflow fix
* fix(ux): make the Zellij mouse interaction work
* fix(rendering): only render if selection/floating-pane position was changed
* do not clear copied to clipboard message on mouse motion
* various functionality fixes
* fix tests
* fixes and cleanups
* style(fmt): rustfmt
* fix(mouse): only report state to plugins when it changed
* fix(plugins): send mouse clicks to inactive panes
* tests: any event tracking in panes
* style(fmt): rustfmt
* style: remove unused stuff
---------
Signed-off-by: Soc Virnyl Estela <contact@uncomfyhalomacro.pl>
Co-authored-by: Autumn Lamonte <AutumnWalksTheLake@gmail.com>
Co-authored-by: Aram Drevekenin <aram@poor.dev>
Co-authored-by: Zykino <Zykino@users.noreply.github.com>
Co-authored-by: Zykino <3809938+Zykino@users.noreply.github.com>
Co-authored-by: Daniel Jankowski <Daniel.Jankowski@rub.de>
Co-authored-by: Manuel de Prada Corral <6536835+manueldeprada@users.noreply.github.com>
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Co-authored-by: Michael Jones <yardquit@pm.me>
Co-authored-by: carl <44021312+achristmascarl@users.noreply.github.com>
Co-authored-by: Evthestrike <62308745+Evthestrike@users.noreply.github.com>
Co-authored-by: Evan Lauer <evanlauer@u.boisestate.edu>
Co-authored-by: Rafael Bardini <rbardini@users.noreply.github.com>
Co-authored-by: Bruno Mesquita <brunocmesquita@gmail.com>
Co-authored-by: Bruno Mesquita <bmesquita@atlassian.com>
Co-authored-by: Chromo-residuum-opec <x@matte.fyi>
Co-authored-by: Shone Binu <62597277+shonebinu@users.noreply.github.com>
Co-authored-by: Mike Greiling <mike@pixelcog.com>
Co-authored-by: Soc Virnyl S. Estela <socvirnyl.estela+github@uncomfyhalomacro.pl>
Co-authored-by: Eric Raio <43896+ericraio@users.noreply.github.com>
Co-authored-by: Vasileios Manolopoulos <44965914+VasilisManol@users.noreply.github.com>
Co-authored-by: Vasilis Manolopoulos <vmanolop@gmail.comh>
Co-authored-by: tranzystorekk <tranzystorek.io@protonmail.com>
Co-authored-by: s1syph0s <34000276+s1syph0s@users.noreply.github.com>
Co-authored-by: Darren Burns <darrenburns@users.noreply.github.com>
* working across tabs and floating panes through the cli
* finalize cli command
* plugin api
* style(fmt): rustfmt
* fix: re-focus pane in stack if it was focused
* style(fmt): rustfmt
* remove outdated comment
* initial draft
* working with floating panes as well
* use the same method for applying an initial layout to tiled panes
* some refactoring
* all code paths working with logical positioning fallback!
* get tests to compile
* get e2e tests to pass
* fix e2e remote runner
* breadth-first layout sorting
* fix some bugs
* style(fmt): rustfmt
* style(fmt): remove comments
* working
* ui indication
* add keybinding
* add to plugin panes
* fix with multiple cursors
* toggle with the mouse
* fix e2e tests and add new one
* some cleanups
* add to layouts
* make mouse click more lenient
* allow setting a new floating pane as pinned
* make toggle work throughthe command line
* add to plugin api
* get tests to pass
* style(fmt): rustfmt
* resize_pane_with_id and close_pane_with_id
* focus_pane_with_id and edit_scrollback_for_pane_with_id
* write_to_pane_id and write_chars_to_pane_id
* lots more commands
* style(fmt): rustfmt
* change simplified_ui at runtime
* change default_shell at runtime
* change pane_frames (from config) at runtime
* all other options
* some refactoring
* style(fmt): rustfmt
* parse kitty keys from STDIN
* work
* work
* replace internal Key representation with the new KeyWithModifier in all the places
* work
* work
* allow disabling with config
* adjust ordering
* handle enabling/disabling properly on the client
* support multiple modifiers without kitty too
* normalize uppercase keys
* get tests to pass
* various cleanups
* style(fmt): rustfmt
* working prototype with passing tests
* new tests and passing plugin tests as well
* style(code): cleanups
* cleanup strider from unused search feature
* prototype of removing old plugin block from the config
* aliases working from config file and all tests passing
* fixups and cleanups
* use aliases in layouts
* update test snapshot
* style(fmt): rustfmt
* refactor: Simplify transfer_rows_from_viewport_to_lines_above
next_lines is always consolidated to a single Row, which immediately
gets removed - we can remove some dead code as a result
* perf: Batch remove rows from the viewport for performance
Given a 1MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~9s to ~3s
* perf: Optimize Row::drain_until by splitting chars in one step
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~23s to ~20s
* refactor: Simplify `if let` into a `.map`
* refactor: There are only new saved coordinates when there were old ones
* refactor: Unify viewport transfer: use common variable names
* fix: Use same saved cursor logic in height resize as width
See #2182 for original introduction that only added it in one branch,
this fixes an issue where the saved cursor was incorrectly reset when
the real cursor was
* fix: Correct saved+real cursor calculations when reflowing long lines
* fix: Don't create canonical lines if cursor ends on EOL after resize
Previously if a 20 character line were split into two 10 character
lines, the cursor would be placed on the line after the two lines.
New characters would then be treated as a new canonical line. This
commit fixes this by biasing cursors to the end of the previous line.
* fix: for cursor index calculation in lines that are already wrapped
* chore: test for real/saved cursor position being handled separately
* chore: Apply cargo format
* refactor: Unify viewport transfer: transfer + cursor update together
* perf: Reduce size of TerminalCharacter from 72 to 60 bytes
With a 10MB single line catted into a fresh terminal, VmRSS goes from
964092 kB to 874020 kB (as reported by /proc/<pid>/status) before/after
this patch
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~15s to ~12.5s
* fix(build): Don't unconditionally rebuild zellij-utils
* refactor: Remove Copy impl on TerminalCharacter
* perf: Rc styles to reduce TerminalCharacter from 60 to 24 bytes
With a 10MB single line catted into a fresh terminal, VmRSS goes from
845156 kB to 478396 kB (as reported by /proc/<pid>/status) before/after
this patch
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~12.5s to ~7s
* perf: Remove RcCharacterStyles::Default, allow enum niche optimisation
This reduces TerminalCharacter from 24 to 16 bytes
With a 10MB single line catted into a fresh terminal, VmRSS goes from
478396 kB to 398108 kB (as reported by /proc/<pid>/status) before/after
this patch
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~7s to ~4.75s
* docs: link anchor omission from reset_all is deliberate
reset_all is only used from ansi params, and ansi params don't control
link anchor
* fix: Remove no-op on variable that gets immediately dropped
* refactor: Simplify replace_character_at logic
The original condition checked absolute_x_index was in bounds, then
used the index to manipulate it. This is equivalent to getting a
ref to the character at that position and manipulating directly
* chore: Run xtask format
* chore(repo): update issue templates
* Bump rust version to 1.75.0 (#3039)
* rust-toolchain: Bump toolchain version to 1.69.0
which, compared to the previous 1.67.0, has the following impacts on
`zellij`:
- [Turn off debuginfo for build deps][2]: Increases build time (on my
machine) from ~230 s in 1.67.0 to ~250 s now, *which is unexpected*
This version also changes [handling of the `default-features` flag][3]
when specifying dependencies in `Cargo.toml`. If a dependent crate
requires `default-features = true` on a crate that is required as
`default-features = false` further up the dependency tree, the `true`
setting "wins". We only specify `default-features = false` for three
crates total:
- `names`: This is used only by us
- `surf`: This is used only by us
- `vte`: This is also required by `strip-ansi-escapes`, but that has
`default-features = false` as well
How this affects our transitive dependencies is unknown at this point.
[2]: https://github.com/rust-lang/cargo/pull/11252/
[3]: https://github.com/rust-lang/cargo/pull/11409/
* rust-toolchain: Bump toolchain version to 1.70.0
which, compared to the previous 1.69.0, as the following impacts on
`zellij`:
1. [Enable sparse registry checkout for crates.io by default][1]
This drastically increases the time to first build on a fresh rust
installation/a rust installation with a clean cargo registry cache.
Previously it took about 75s to populate the deps/cache (with `cargo
fetch --locked` and ~100 MBit/s network), whereas now the same process
takes ~10 s.
2. [The `OnceCell` type is now part of std][2]
In theory, this would allow us to cut a dependency from `zellij-utils`,
but the `once_cell` crate is pulled in by another 16 deps, so there's no
point in attempting it right now.
Build times and binary sizes are unaffected by this change compared to
the previous 1.69.0 toolchain.
[1]: https://github.com/rust-lang/cargo/pull/11791/
[2]: https://doc.rust-lang.org/stable/std/cell/struct.OnceCell.html
* rust-toolchain: Bump toolchain version to 1.75.0
which, compared to the previous 1.70.0, has the following impacts on
`zellij`:
1. [cross-crate inlining][8]
This should increase application performance, as functions can now be
inlined across crates.
2. [`async fn` in traits][9]
This would allow us to drop the `async_trait` dependency, but it is
currently still required by 3 other dependencies.
Build time in debug mode (on my own PC) is cut down from 256s to 189s
(for a clean build). Build time in release mode is cut down from 473s to
391s (for a clean build). Binary sizes only change minimally (825 MB ->
807 MB in debug, 29 MB -> 30 MB in release).
[8]: https://github.com/rust-lang/rust/pull/116505
[9]: https://github.com/rust-lang/rust/pull/115822/
* chore: Apply rustfmt.
* CHANGELOG: Add PR #3039.
* feat(plugins): introduce 'pipes', allowing users to pipe data to and control plugins from the command line (#3066)
* prototype - working with message from the cli
* prototype - pipe from the CLI to plugins
* prototype - pipe from the CLI to plugins and back again
* prototype - working with better cli interface
* prototype - working after removing unused stuff
* prototype - working with launching plugin if it is not launched, also fixed event ordering
* refactor: change message to cli-message
* prototype - allow plugins to send messages to each other
* fix: allow cli messages to send plugin parameters (and implement backpressure)
* fix: use input_pipe_id to identify cli pipes instead of their message name
* fix: come cleanups and add skip_cache parameter
* fix: pipe/client-server communication robustness
* fix: leaking messages between plugins while loading
* feat: allow plugins to specify how a new plugin instance is launched when sending messages
* fix: add permissions
* refactor: adjust cli api
* fix: improve cli plugin loading error messages
* docs: cli pipe
* fix: take plugin configuration into account when messaging between plugins
* refactor: pipe message protobuf interface
* refactor: update(event) -> pipe
* refactor - rename CliMessage to CliPipe
* fix: add is_private to pipes and change some naming
* refactor - cli client
* refactor: various cleanups
* style(fmt): rustfmt
* fix(pipes): backpressure across multiple plugins
* style: some cleanups
* style(fmt): rustfmt
* style: fix merge conflict mistake
* style(wording): clarify pipe permission
* docs(changelog): introduce pipes
* xtask: Disable pusing during publish (#3040)
* xtask: Add `--no-push` flag to `publish`
which can be used when simulating releases to work without a writable
git fork of the zellij code.
* xtask: Fix borrow issues
* xtask/pipe: Require lockfile in publish
to avoid errors from invalid dependency versions.
* CHANGELOG: Add PR #3040.
* fix(terminal): some real/saved cursor bugs during resize (#3032)
* refactor: Simplify transfer_rows_from_viewport_to_lines_above
next_lines is always consolidated to a single Row, which immediately
gets removed - we can remove some dead code as a result
* perf: Batch remove rows from the viewport for performance
Given a 1MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~9s to ~3s
* perf: Optimize Row::drain_until by splitting chars in one step
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~23s to ~20s
* refactor: Simplify `if let` into a `.map`
* refactor: There are only new saved coordinates when there were old ones
* refactor: Unify viewport transfer: use common variable names
* fix: Use same saved cursor logic in height resize as width
See #2182 for original introduction that only added it in one branch,
this fixes an issue where the saved cursor was incorrectly reset when
the real cursor was
* fix: Correct saved+real cursor calculations when reflowing long lines
* fix: Don't create canonical lines if cursor ends on EOL after resize
Previously if a 20 character line were split into two 10 character
lines, the cursor would be placed on the line after the two lines.
New characters would then be treated as a new canonical line. This
commit fixes this by biasing cursors to the end of the previous line.
* fix: for cursor index calculation in lines that are already wrapped
* chore: test for real/saved cursor position being handled separately
* chore: Apply cargo format
* chore(repo): update issue templates
* Bump rust version to 1.75.0 (#3039)
* rust-toolchain: Bump toolchain version to 1.69.0
which, compared to the previous 1.67.0, has the following impacts on
`zellij`:
- [Turn off debuginfo for build deps][2]: Increases build time (on my
machine) from ~230 s in 1.67.0 to ~250 s now, *which is unexpected*
This version also changes [handling of the `default-features` flag][3]
when specifying dependencies in `Cargo.toml`. If a dependent crate
requires `default-features = true` on a crate that is required as
`default-features = false` further up the dependency tree, the `true`
setting "wins". We only specify `default-features = false` for three
crates total:
- `names`: This is used only by us
- `surf`: This is used only by us
- `vte`: This is also required by `strip-ansi-escapes`, but that has
`default-features = false` as well
How this affects our transitive dependencies is unknown at this point.
[2]: https://github.com/rust-lang/cargo/pull/11252/
[3]: https://github.com/rust-lang/cargo/pull/11409/
* rust-toolchain: Bump toolchain version to 1.70.0
which, compared to the previous 1.69.0, as the following impacts on
`zellij`:
1. [Enable sparse registry checkout for crates.io by default][1]
This drastically increases the time to first build on a fresh rust
installation/a rust installation with a clean cargo registry cache.
Previously it took about 75s to populate the deps/cache (with `cargo
fetch --locked` and ~100 MBit/s network), whereas now the same process
takes ~10 s.
2. [The `OnceCell` type is now part of std][2]
In theory, this would allow us to cut a dependency from `zellij-utils`,
but the `once_cell` crate is pulled in by another 16 deps, so there's no
point in attempting it right now.
Build times and binary sizes are unaffected by this change compared to
the previous 1.69.0 toolchain.
[1]: https://github.com/rust-lang/cargo/pull/11791/
[2]: https://doc.rust-lang.org/stable/std/cell/struct.OnceCell.html
* rust-toolchain: Bump toolchain version to 1.75.0
which, compared to the previous 1.70.0, has the following impacts on
`zellij`:
1. [cross-crate inlining][8]
This should increase application performance, as functions can now be
inlined across crates.
2. [`async fn` in traits][9]
This would allow us to drop the `async_trait` dependency, but it is
currently still required by 3 other dependencies.
Build time in debug mode (on my own PC) is cut down from 256s to 189s
(for a clean build). Build time in release mode is cut down from 473s to
391s (for a clean build). Binary sizes only change minimally (825 MB ->
807 MB in debug, 29 MB -> 30 MB in release).
[8]: https://github.com/rust-lang/rust/pull/116505
[9]: https://github.com/rust-lang/rust/pull/115822/
* chore: Apply rustfmt.
* CHANGELOG: Add PR #3039.
* feat(plugins): introduce 'pipes', allowing users to pipe data to and control plugins from the command line (#3066)
* prototype - working with message from the cli
* prototype - pipe from the CLI to plugins
* prototype - pipe from the CLI to plugins and back again
* prototype - working with better cli interface
* prototype - working after removing unused stuff
* prototype - working with launching plugin if it is not launched, also fixed event ordering
* refactor: change message to cli-message
* prototype - allow plugins to send messages to each other
* fix: allow cli messages to send plugin parameters (and implement backpressure)
* fix: use input_pipe_id to identify cli pipes instead of their message name
* fix: come cleanups and add skip_cache parameter
* fix: pipe/client-server communication robustness
* fix: leaking messages between plugins while loading
* feat: allow plugins to specify how a new plugin instance is launched when sending messages
* fix: add permissions
* refactor: adjust cli api
* fix: improve cli plugin loading error messages
* docs: cli pipe
* fix: take plugin configuration into account when messaging between plugins
* refactor: pipe message protobuf interface
* refactor: update(event) -> pipe
* refactor - rename CliMessage to CliPipe
* fix: add is_private to pipes and change some naming
* refactor - cli client
* refactor: various cleanups
* style(fmt): rustfmt
* fix(pipes): backpressure across multiple plugins
* style: some cleanups
* style(fmt): rustfmt
* style: fix merge conflict mistake
* style(wording): clarify pipe permission
* docs(changelog): introduce pipes
* fix: add some robustness and future proofing
* fix e2e tests
---------
Co-authored-by: Aram Drevekenin <aram@poor.dev>
Co-authored-by: har7an <99636919+har7an@users.noreply.github.com>
* fix integer overflow again (oops)
---------
Co-authored-by: Aram Drevekenin <aram@poor.dev>
Co-authored-by: har7an <99636919+har7an@users.noreply.github.com>
* refactor: Simplify transfer_rows_from_viewport_to_lines_above
next_lines is always consolidated to a single Row, which immediately
gets removed - we can remove some dead code as a result
* perf: Batch remove rows from the viewport for performance
Given a 1MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~9s to ~3s
* perf: Optimize Row::drain_until by splitting chars in one step
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~23s to ~20s
* refactor: Simplify `if let` into a `.map`
* refactor: There are only new saved coordinates when there were old ones
* refactor: Unify viewport transfer: use common variable names
* fix: Use same saved cursor logic in height resize as width
See #2182 for original introduction that only added it in one branch,
this fixes an issue where the saved cursor was incorrectly reset when
the real cursor was
* fix: Correct saved+real cursor calculations when reflowing long lines
* fix: Don't create canonical lines if cursor ends on EOL after resize
Previously if a 20 character line were split into two 10 character
lines, the cursor would be placed on the line after the two lines.
New characters would then be treated as a new canonical line. This
commit fixes this by biasing cursors to the end of the previous line.
* fix: for cursor index calculation in lines that are already wrapped
* chore: test for real/saved cursor position being handled separately
* chore: Apply cargo format
* chore(repo): update issue templates
* Bump rust version to 1.75.0 (#3039)
* rust-toolchain: Bump toolchain version to 1.69.0
which, compared to the previous 1.67.0, has the following impacts on
`zellij`:
- [Turn off debuginfo for build deps][2]: Increases build time (on my
machine) from ~230 s in 1.67.0 to ~250 s now, *which is unexpected*
This version also changes [handling of the `default-features` flag][3]
when specifying dependencies in `Cargo.toml`. If a dependent crate
requires `default-features = true` on a crate that is required as
`default-features = false` further up the dependency tree, the `true`
setting "wins". We only specify `default-features = false` for three
crates total:
- `names`: This is used only by us
- `surf`: This is used only by us
- `vte`: This is also required by `strip-ansi-escapes`, but that has
`default-features = false` as well
How this affects our transitive dependencies is unknown at this point.
[2]: https://github.com/rust-lang/cargo/pull/11252/
[3]: https://github.com/rust-lang/cargo/pull/11409/
* rust-toolchain: Bump toolchain version to 1.70.0
which, compared to the previous 1.69.0, as the following impacts on
`zellij`:
1. [Enable sparse registry checkout for crates.io by default][1]
This drastically increases the time to first build on a fresh rust
installation/a rust installation with a clean cargo registry cache.
Previously it took about 75s to populate the deps/cache (with `cargo
fetch --locked` and ~100 MBit/s network), whereas now the same process
takes ~10 s.
2. [The `OnceCell` type is now part of std][2]
In theory, this would allow us to cut a dependency from `zellij-utils`,
but the `once_cell` crate is pulled in by another 16 deps, so there's no
point in attempting it right now.
Build times and binary sizes are unaffected by this change compared to
the previous 1.69.0 toolchain.
[1]: https://github.com/rust-lang/cargo/pull/11791/
[2]: https://doc.rust-lang.org/stable/std/cell/struct.OnceCell.html
* rust-toolchain: Bump toolchain version to 1.75.0
which, compared to the previous 1.70.0, has the following impacts on
`zellij`:
1. [cross-crate inlining][8]
This should increase application performance, as functions can now be
inlined across crates.
2. [`async fn` in traits][9]
This would allow us to drop the `async_trait` dependency, but it is
currently still required by 3 other dependencies.
Build time in debug mode (on my own PC) is cut down from 256s to 189s
(for a clean build). Build time in release mode is cut down from 473s to
391s (for a clean build). Binary sizes only change minimally (825 MB ->
807 MB in debug, 29 MB -> 30 MB in release).
[8]: https://github.com/rust-lang/rust/pull/116505
[9]: https://github.com/rust-lang/rust/pull/115822/
* chore: Apply rustfmt.
* CHANGELOG: Add PR #3039.
* feat(plugins): introduce 'pipes', allowing users to pipe data to and control plugins from the command line (#3066)
* prototype - working with message from the cli
* prototype - pipe from the CLI to plugins
* prototype - pipe from the CLI to plugins and back again
* prototype - working with better cli interface
* prototype - working after removing unused stuff
* prototype - working with launching plugin if it is not launched, also fixed event ordering
* refactor: change message to cli-message
* prototype - allow plugins to send messages to each other
* fix: allow cli messages to send plugin parameters (and implement backpressure)
* fix: use input_pipe_id to identify cli pipes instead of their message name
* fix: come cleanups and add skip_cache parameter
* fix: pipe/client-server communication robustness
* fix: leaking messages between plugins while loading
* feat: allow plugins to specify how a new plugin instance is launched when sending messages
* fix: add permissions
* refactor: adjust cli api
* fix: improve cli plugin loading error messages
* docs: cli pipe
* fix: take plugin configuration into account when messaging between plugins
* refactor: pipe message protobuf interface
* refactor: update(event) -> pipe
* refactor - rename CliMessage to CliPipe
* fix: add is_private to pipes and change some naming
* refactor - cli client
* refactor: various cleanups
* style(fmt): rustfmt
* fix(pipes): backpressure across multiple plugins
* style: some cleanups
* style(fmt): rustfmt
* style: fix merge conflict mistake
* style(wording): clarify pipe permission
* docs(changelog): introduce pipes
* fix: add some robustness and future proofing
* fix e2e tests
---------
Co-authored-by: Aram Drevekenin <aram@poor.dev>
Co-authored-by: har7an <99636919+har7an@users.noreply.github.com>
* refactor: Simplify transfer_rows_from_viewport_to_lines_above
next_lines is always consolidated to a single Row, which immediately
gets removed - we can remove some dead code as a result
* perf: Batch remove rows from the viewport for performance
Given a 1MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~9s to ~3s
* perf: Optimize Row::drain_until by splitting chars in one step
Given a 10MB line catted into the terminal, a toggle-fullscreen +
toggle-fullscreen + close-pane + `run true` goes from ~23s to ~20s
* prototype - working with message from the cli
* prototype - pipe from the CLI to plugins
* prototype - pipe from the CLI to plugins and back again
* prototype - working with better cli interface
* prototype - working after removing unused stuff
* prototype - working with launching plugin if it is not launched, also fixed event ordering
* refactor: change message to cli-message
* prototype - allow plugins to send messages to each other
* fix: allow cli messages to send plugin parameters (and implement backpressure)
* fix: use input_pipe_id to identify cli pipes instead of their message name
* fix: come cleanups and add skip_cache parameter
* fix: pipe/client-server communication robustness
* fix: leaking messages between plugins while loading
* feat: allow plugins to specify how a new plugin instance is launched when sending messages
* fix: add permissions
* refactor: adjust cli api
* fix: improve cli plugin loading error messages
* docs: cli pipe
* fix: take plugin configuration into account when messaging between plugins
* refactor: pipe message protobuf interface
* refactor: update(event) -> pipe
* refactor - rename CliMessage to CliPipe
* fix: add is_private to pipes and change some naming
* refactor - cli client
* refactor: various cleanups
* style(fmt): rustfmt
* fix(pipes): backpressure across multiple plugins
* style: some cleanups
* style(fmt): rustfmt
* style: fix merge conflict mistake
* style(wording): clarify pipe permission
