Add/ci enable clippy (#1509)

* fix(clippy): clippy fixes

* add(ci): enable clippy warnings

* chore(fmt): cargo fmt

* disable: failing clippy action

Add `cargo make clippy` in ci

.github/workflows/rust.yml

@@ -72,8 +72,10 @@ jobs:
           ~/.cargo/git
           target
         key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-    - name: Check Lints
-      uses: actions-rs/clippy-check@v1
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        args: --all-features --all-targets
+    - name: Check clippy lints
+      run: cargo make clippy
+    # - name: Check Lints
+    #   uses: actions-rs/clippy-check@v1
+    #   with:
+    #     token: ${{ secrets.GITHUB_TOKEN }}
+    #     args: --all-features --all-targets --deny warnings

Makefile.toml

@@ -92,7 +92,7 @@ args = [
 
 # Simple clippy tweak
 [tasks.clippy]
-args = ["clippy", "--all-targets","--all-features","--", "@@split(CARGO_MAKE_TASK_ARGS,;)"]
+args = ["clippy", "--all-targets","--all-features","--","--deny","warnings", "@@split(CARGO_MAKE_TASK_ARGS,;)"]
 
 # Release building and installing Zellij
 [tasks.install]