pogmommy/zellij
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(render): various rendering issues (#238)

Browse source
This commit is contained in:
Aram Drevekenin 2021-03-24 10:58:50 +01:00 • committed by GitHub
parent d64e814e54
commit e1e1f21043
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/client/panes/terminal_pane.rs
View file

@ -188,7 +188,14 @@ impl Pane for TerminalPane {
self.max_height self.max_height
} }
fn render(&mut self) -> Option<String> { fn render(&mut self) -> Option<String> {
if self.should_render || cfg!(test) { // FIXME:
// the below conditional is commented out because it causes several bugs:
// 1. When panes are resized or tabs are switched the previous contents of the screen stick
// around
// 2. When there are wide characters in a pane, since we don't yet handle them properly,
// the spill over to the pane to the right
// if self.should_render || cfg!(test) {
if true {
let mut vte_output = String::new(); let mut vte_output = String::new();
let buffer_lines = &self.read_buffer_as_lines(); let buffer_lines = &self.read_buffer_as_lines();
let display_cols = self.get_columns(); let display_cols = self.get_columns();